From eeb5b21943fd21910194b3e4b73554aced96126b Mon Sep 17 00:00:00 2001 From: yosefalnajjarofficial Date: Fri, 10 Jan 2020 13:21:38 +0200 Subject: [PATCH 1/2] trim the traling slash from the display URL Relates #156 --- src/components/Person.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/Person.js b/src/components/Person.js index 8ab35af7..76246bb9 100644 --- a/src/components/Person.js +++ b/src/components/Person.js @@ -18,10 +18,9 @@ export default function Person({ person, currentTag }) { {person.name} {person.emoji} - {`${url.host}${url.pathname}`} + {`${ + url.host + }${url.pathname.slice(0, url.pathname.lastIndexOf('/'))}`}

{person.description}

@@ -77,6 +76,7 @@ Person.propTypes = { emoji: PropTypes.string, description: PropTypes.string, tags: PropTypes.arrayOf(PropTypes.string), + country: PropTypes.string, computer: PropTypes.oneOf(['apple', 'windows', 'linux']), phone: PropTypes.oneOf(['iphone', 'android']), twitter(props, propName, componentName) { From 42b3588416a96b9f1affdd7de3af8f3a41d220b4 Mon Sep 17 00:00:00 2001 From: Kasper Jacobsen Date: Fri, 10 Jan 2020 12:52:44 +0100 Subject: [PATCH 2/2] Make sure long links does not break the design --- src/components/Person.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/components/Person.js b/src/components/Person.js index 8ab35af7..7a6b3574 100644 --- a/src/components/Person.js +++ b/src/components/Person.js @@ -118,6 +118,9 @@ const PersonInner = styled.div` font-size: 1rem; } .displayLink { + white-space: nowrap; + overflow: hidden; + text-overflow: ellipsis; text-decoration: none; color: var(--vape); letter-spacing: 1px;