Commit graph

20 commits

Author SHA1 Message Date
Rohit Gohri
61e1aeeb36 ci: use danger diff to get master data 2020-05-04 00:35:42 +05:30
Rohit Gohri
ef972cf38f ci: better formatted messages 2020-05-04 00:12:42 +05:30
Rohit Gohri
38464bf065 ci: Move comment creation to dangerfile 2020-05-03 23:58:55 +05:30
Rohit Gohri
2f2ce100fd ci: show all errors in comment/log 2020-05-03 23:25:24 +05:30
Rohit Gohri
afced1a6b7 ci: delete old data-validate step 2020-05-03 23:23:30 +05:30
Rohit Gohri
9426b956e6 ci: add danger-js and add validation dangerfile 2020-05-03 23:14:56 +05:30
Rohit Gohri
c7691e3200 chore: run validate script only when run directly 2020-05-03 23:00:51 +05:30
Hugo
e20e0f5991 feat: comment on PR with validation outcome (#503)
* comment on PR after validation run.

* bork my url for sample output

* populate GITHUB_TOKEN in action

* more verbose logging

* more logging

* fix wrong import

* logging

* remove logging & implementation attempt

* log out comment creation query output

* styling

* prettify comments + increase logging

* more prettifying of the text

* Revert "bork my url for sample output"

This reverts commit 0c6d17450e753cd407db69a8129bf0cbc5831b88.

* add data change to trigger GH action

* improve messages...

* change my URL so it appears in the message

* more formatting of comments

* move + rename commentPullRequest -> utils.communicateValationOutcome
2020-01-22 00:15:35 +02:00
Andrew Luca
7893bc510c
chore: downgrade scripts support to node 12 (#473)
From start scripts needed to be run with node 13 (esm support)
Because data.js was a esm export, and needed to be compiled
Moved all scripts to commontjs, and data.js file
So can be imported by scripts without compiling
2020-01-20 22:37:32 +02:00
Andrew Luca
86b6b5d6d3
feat: change validate action to take into consideration only add… (#422)
`node scripts/data-valdiate.js` cand also be run locally

This also will fix the issue when some valid URL returned timeout
Because the action wanted to make all requests at the same time

`git restore` is available only from Git 2.23

https://github.blog/2019-08-16-highlights-from-git-2-23/#experimental-alternatives-for-git-checkout

Closes #382
2020-01-18 15:27:15 +02:00
Hugo Di Francesco
1df5931b5a exit fine locally 2020-01-13 18:04:04 +00:00
Hugo Di Francesco
053874e441 make action fail on failure... 2020-01-13 18:02:15 +00:00
Hugo Di Francesco
bc1475090f Merge remote-tracking branch 'upstream/master' into check-url 2020-01-13 17:40:18 +00:00
Hugo Di Francesco
2bd152678b increase request timeout 2020-01-13 16:11:01 +00:00
Hugo Di Francesco
0e4168908c only fail on 4xx, 5xx and other real errors 2020-01-13 15:52:44 +00:00
Hugo Di Francesco
d681750ba2 change wording of output 2020-01-13 15:46:03 +00:00
Hugo Di Francesco
2ed2ea5ca1 make sure uses URLs 2xx 2020-01-13 15:38:23 +00:00
Hugo Di Francesco
883dca16ff allow only uses URLs 2020-01-13 15:33:56 +00:00
Wes Bos
3a9ce9d6be better validation 2020-01-10 13:44:02 -05:00
Andrew Luca
ad8cc4a9be
feat: add action to validate data.js
Closes #141
2020-01-10 19:07:55 +02:00