BradNut/graphbrainz
1
0
Fork 0
mirror of https://github.com/BradNut/graphbrainz synced 2025-09-08 17:40:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Reconsider test indentation

Browse source
This commit is contained in:
Brian Beck 2016-12-11 12:37:25 -08:00
parent b2ec20ed2c
commit 195e9fdb7c
1 changed files with 398 additions and 419 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

141
test/schema.js
View file

@ -18,8 +18,7 @@ function testError (t, query, handler) {
}) })
} }
test('schema has a node field', testData, test('schema has a node field', testData, `
`
{ {
node(id: "UmVsZWFzZUdyb3VwOmUzN2QyNzQwLTQ1MDMtNGUzZi1hYjZkLWU2MjJhMjVlOTY0ZA==") { node(id: "UmVsZWFzZUdyb3VwOmUzN2QyNzQwLTQ1MDMtNGUzZi1hYjZkLWU2MjJhMjVlOTY0ZA==") {
__typename __typename
@ -28,18 +27,16 @@ test('schema has a node field', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
t.deepEqual(data, { t.deepEqual(data, {
node: { node: {
__typename: 'ReleaseGroup', __typename: 'ReleaseGroup',
mbid: 'e37d2740-4503-4e3f-ab6d-e622a25e964d' mbid: 'e37d2740-4503-4e3f-ab6d-e622a25e964d'
} }
}) })
} })
)
test('schema has a lookup query', testData, test('schema has a lookup query', testData, `
`
{ {
lookup { lookup {
artist (mbid: "c8da2e40-bd28-4d4e-813a-bd2f51958ba8") { artist (mbid: "c8da2e40-bd28-4d4e-813a-bd2f51958ba8") {
@ -49,7 +46,7 @@ test('schema has a lookup query', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
t.deepEqual(data, { t.deepEqual(data, {
lookup: { lookup: {
artist: { artist: {
@ -59,10 +56,9 @@ test('schema has a lookup query', testData,
} }
} }
}) })
}) })
test('schema has a search query', testData, test('schema has a search query', testData, `
`
{ {
search { search {
recordings (query: "Burn the Witch") { recordings (query: "Burn the Witch") {
@ -77,15 +73,14 @@ test('schema has a search query', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { recordings } = data.search const { recordings } = data.search
t.true(recordings.totalCount > 0) t.true(recordings.totalCount > 0)
t.true(recordings.edges.length === 25) t.true(recordings.edges.length === 25)
recordings.edges.forEach(edge => t.true(edge.score > 0)) recordings.edges.forEach(edge => t.true(edge.score > 0))
}) })
test('schema has a browse query', testData, test('schema has a browse query', testData, `
`
{ {
browse { browse {
releaseGroups (artist: "c8da2e40-bd28-4d4e-813a-bd2f51958ba8") { releaseGroups (artist: "c8da2e40-bd28-4d4e-813a-bd2f51958ba8") {
@ -106,15 +101,14 @@ test('schema has a browse query', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { releaseGroups } = data.browse const { releaseGroups } = data.browse
t.true(releaseGroups.totalCount > 0) t.true(releaseGroups.totalCount > 0)
t.true(releaseGroups.edges.length > 0) t.true(releaseGroups.edges.length > 0)
releaseGroups.edges.forEach(edge => t.truthy(edge.node.title)) releaseGroups.edges.forEach(edge => t.truthy(edge.node.title))
}) })
test('supports deeply nested queries', testData, test('supports deeply nested queries', testData, `
`
query AppleRecordsMarriages { query AppleRecordsMarriages {
search { search {
labels(query: "Apple Records", first: 1) { labels(query: "Apple Records", first: 1) {
@ -182,14 +176,13 @@ test('supports deeply nested queries', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { labels } = data.search const { labels } = data.search
t.true(labels.edges.length > 0) t.true(labels.edges.length > 0)
t.is(labels.edges[0].node.releases.edges.length, 1) t.is(labels.edges[0].node.releases.edges.length, 1)
}) })
test('throws an error if given a malformed MBID', testError, test('throws an error if given a malformed MBID', testError, `
`
{ {
lookup { lookup {
artist(mbid: "ABC123") { artist(mbid: "ABC123") {
@ -197,14 +190,13 @@ test('throws an error if given a malformed MBID', testError,
} }
} }
} }
`, (t, errors) => { `, (t, errors) => {
const err = errors[0] const err = errors[0]
t.true(err instanceof TypeError) t.true(err instanceof TypeError)
t.is(err.message, 'Malformed MBID: ABC123') t.is(err.message, 'Malformed MBID: ABC123')
}) })
test('Artist beginArea/endArea pulls from begin_area/end_area for lookup queries', testData, test('Artist beginArea/endArea pulls from begin_area/end_area for lookup queries', testData, `
`
{ {
lookup { lookup {
artist(mbid: "65314b12-0e08-43fa-ba33-baaa7b874c15") { artist(mbid: "65314b12-0e08-43fa-ba33-baaa7b874c15") {
@ -217,14 +209,13 @@ test('Artist beginArea/endArea pulls from begin_area/end_area for lookup queries
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { artist } = data.lookup const { artist } = data.lookup
t.is(artist.beginArea.name, 'Westmount') t.is(artist.beginArea.name, 'Westmount')
t.is(artist.endArea.name, 'Los Angeles') t.is(artist.endArea.name, 'Los Angeles')
}) })
test('Artist beginArea/endArea pull from begin_area/end_area for browse queries', testData, test('Artist beginArea/endArea pull from begin_area/end_area for browse queries', testData, `
`
{ {
browse { browse {
artists(area: "3f504d54-c40c-487d-bc16-c1990eac887f") { artists(area: "3f504d54-c40c-487d-bc16-c1990eac887f") {
@ -241,15 +232,14 @@ test('Artist beginArea/endArea pull from begin_area/end_area for browse queries'
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const artists = data.browse.artists.edges.map(edge => edge.node) const artists = data.browse.artists.edges.map(edge => edge.node)
t.true(artists.length > 1) t.true(artists.length > 1)
t.true(artists.some(artist => artist.beginArea)) t.true(artists.some(artist => artist.beginArea))
t.true(artists.some(artist => artist.endArea)) t.true(artists.some(artist => artist.endArea))
}) })
test('Artist beginArea/endArea pulls from begin-area/end-area for search queries', testData, test('Artist beginArea/endArea pulls from begin-area/end-area for search queries', testData, `
`
{ {
search { search {
artists(query: "Leonard Cohen", first: 1) { artists(query: "Leonard Cohen", first: 1) {
@ -266,15 +256,14 @@ test('Artist beginArea/endArea pulls from begin-area/end-area for search queries
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const artists = data.search.artists.edges.map(edge => edge.node) const artists = data.search.artists.edges.map(edge => edge.node)
t.true(artists.length === 1) t.true(artists.length === 1)
t.is(artists[0].beginArea.name, 'Westmount') t.is(artists[0].beginArea.name, 'Westmount')
t.is(artists[0].endArea.name, 'Los Angeles') t.is(artists[0].endArea.name, 'Los Angeles')
}) })
test('relationships filter by type', testData, test('relationships filter by type', testData, `
`
{ {
lookup { lookup {
artist(mbid: "65314b12-0e08-43fa-ba33-baaa7b874c15") { artist(mbid: "65314b12-0e08-43fa-ba33-baaa7b874c15") {
@ -313,7 +302,7 @@ test('relationships filter by type', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { relationships } = data.lookup.artist const { relationships } = data.lookup.artist
t.is(relationships.artists.edges.length, 5) t.is(relationships.artists.edges.length, 5)
relationships.artists.edges.forEach(edge => { relationships.artists.edges.forEach(edge => {
@ -330,10 +319,9 @@ test('relationships filter by type', testData,
t.is(edge.node.targetType, 'release') t.is(edge.node.targetType, 'release')
t.is(edge.node.target.__typename, 'Release') t.is(edge.node.target.__typename, 'Release')
}) })
}) })
test('Area maps iso-3166-1-codes to isoCodes', testData, test('Area maps iso-3166-1-codes to isoCodes', testData, `
`
{ {
lookup { lookup {
area(mbid: "489ce91b-6658-3307-9877-795b68554c98") { area(mbid: "489ce91b-6658-3307-9877-795b68554c98") {
@ -342,12 +330,11 @@ test('Area maps iso-3166-1-codes to isoCodes', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
t.deepEqual(data.lookup.area.isoCodes, ['US']) t.deepEqual(data.lookup.area.isoCodes, ['US'])
}) })
test('Alias locales use the Locale scalar', testData, test('Alias locales use the Locale scalar', testData, `
`
{ {
lookup { lookup {
artist(mbid: "f99b7d67-4e63-4678-aa66-4c6ac0f7d24a") { artist(mbid: "f99b7d67-4e63-4678-aa66-4c6ac0f7d24a") {
@ -358,14 +345,13 @@ test('Alias locales use the Locale scalar', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { aliases } = data.lookup.artist const { aliases } = data.lookup.artist
t.is(aliases.find(alias => alias.locale === 'en').name, 'PSY') t.is(aliases.find(alias => alias.locale === 'en').name, 'PSY')
t.is(aliases.find(alias => alias.locale === 'ko').name, '싸이') t.is(aliases.find(alias => alias.locale === 'ko').name, '싸이')
}) })
test('Work ISWCs use the ISWC scalar', testData, test('Work ISWCs use the ISWC scalar', testData, `
`
{ {
lookup { lookup {
work(mbid: "ef7d0814-da6a-32f5-a600-ff81cffd1aed") { work(mbid: "ef7d0814-da6a-32f5-a600-ff81cffd1aed") {
@ -374,14 +360,13 @@ test('Work ISWCs use the ISWC scalar', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { work } = data.lookup const { work } = data.lookup
t.is(work.title, 'Song of the French Partisan') t.is(work.title, 'Song of the French Partisan')
t.deepEqual(work.iswcs, ['T-900.755.682-3']) t.deepEqual(work.iswcs, ['T-900.755.682-3'])
}) })
test('URLs may be looked up by resource', testData, test('URLs may be looked up by resource', testData, `
`
{ {
lookup { lookup {
url(resource: "http://www.nirvana.com/") { url(resource: "http://www.nirvana.com/") {
@ -390,14 +375,13 @@ test('URLs may be looked up by resource', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { url } = data.lookup const { url } = data.lookup
t.is(url.mbid, '4347ffe2-82ec-4059-9520-6a1a3f73a304') t.is(url.mbid, '4347ffe2-82ec-4059-9520-6a1a3f73a304')
t.is(url.resource, 'http://www.nirvana.com/') t.is(url.resource, 'http://www.nirvana.com/')
}) })
test('throws an error if given a malformed URLString', testError, test('throws an error if given a malformed URLString', testError, `
`
{ {
lookup { lookup {
url(resource: "http:foo") { url(resource: "http:foo") {
@ -406,14 +390,13 @@ test('throws an error if given a malformed URLString', testError,
} }
} }
} }
`, (t, errors) => { `, (t, errors) => {
const err = errors[0] const err = errors[0]
t.true(err instanceof TypeError) t.true(err instanceof TypeError)
t.is(err.message, 'Malformed URL: http:foo') t.is(err.message, 'Malformed URL: http:foo')
}) })
test('Release groups can be browsed by type', testData, test('Release groups can be browsed by type', testData, `
`
{ {
browse { browse {
releaseGroups(artist: "5b11f4ce-a62d-471e-81fc-a69a8278c7da", type: EP) { releaseGroups(artist: "5b11f4ce-a62d-471e-81fc-a69a8278c7da", type: EP) {
@ -425,14 +408,13 @@ test('Release groups can be browsed by type', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const releaseGroups = data.browse.releaseGroups.edges.map(edge => edge.node) const releaseGroups = data.browse.releaseGroups.edges.map(edge => edge.node)
t.is(releaseGroups.length, 8) t.is(releaseGroups.length, 8)
releaseGroups.forEach(releaseGroup => t.is(releaseGroup.primaryType, 'EP')) releaseGroups.forEach(releaseGroup => t.is(releaseGroup.primaryType, 'EP'))
}) })
test('Releases can be browsed by type and status', testData, test('Releases can be browsed by type and status', testData, `
`
{ {
browse { browse {
releases(artist: "5b11f4ce-a62d-471e-81fc-a69a8278c7da", type: EP, status: BOOTLEG) { releases(artist: "5b11f4ce-a62d-471e-81fc-a69a8278c7da", type: EP, status: BOOTLEG) {
@ -444,14 +426,13 @@ test('Releases can be browsed by type and status', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const releases = data.browse.releases.edges.map(edge => edge.node) const releases = data.browse.releases.edges.map(edge => edge.node)
t.is(releases.length, 6) t.is(releases.length, 6)
releases.forEach(release => t.is(release.status, 'BOOTLEG')) releases.forEach(release => t.is(release.status, 'BOOTLEG'))
}) })
test('Releases have an ASIN field', testData, test('Releases have an ASIN field', testData, `
`
{ {
lookup { lookup {
release(mbid: "d5cdb7fd-c7e9-460a-9549-8a369655cc52") { release(mbid: "d5cdb7fd-c7e9-460a-9549-8a369655cc52") {
@ -459,13 +440,12 @@ test('Releases have an ASIN field', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { release } = data.lookup const { release } = data.lookup
t.is(release.asin, 'B01KN6XDS6') t.is(release.asin, 'B01KN6XDS6')
}) })
test('Artists have a list of ISNIs and IPIs', testData, test('Artists have a list of ISNIs and IPIs', testData, `
`
{ {
lookup { lookup {
artist(mbid: "65314b12-0e08-43fa-ba33-baaa7b874c15") { artist(mbid: "65314b12-0e08-43fa-ba33-baaa7b874c15") {
@ -474,14 +454,13 @@ test('Artists have a list of ISNIs and IPIs', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { artist } = data.lookup const { artist } = data.lookup
t.deepEqual(artist.ipis, ['00006457004']) t.deepEqual(artist.ipis, ['00006457004'])
t.deepEqual(artist.isnis, ['0000000110273481']) t.deepEqual(artist.isnis, ['0000000110273481'])
}) })
test('artistCredits is an alias for artistCredit', testData, test('artistCredits is an alias for artistCredit', testData, `
`
{ {
lookup { lookup {
recording(mbid: "07649758-09c8-4d70-bc6f-5c37ab36334d") { recording(mbid: "07649758-09c8-4d70-bc6f-5c37ab36334d") {
@ -516,7 +495,7 @@ test('artistCredits is an alias for artistCredit', testData,
} }
} }
} }
`, (t, data) => { `, (t, data) => {
const { recording, release, releaseGroup } = data.lookup const { recording, release, releaseGroup } = data.lookup
t.deepEqual(recording.artistCredit, [ t.deepEqual(recording.artistCredit, [
{ name: 'Holly Golightly', joinPhrase: ' & ' }, { name: 'Holly Golightly', joinPhrase: ' & ' },
@ -534,4 +513,4 @@ test('artistCredits is an alias for artistCredit', testData,
{ name: 'Ill Bill', joinPhrase: '' } { name: 'Ill Bill', joinPhrase: '' }
]) ])
t.deepEqual(releaseGroup.artistCredits, releaseGroup.artistCredit) t.deepEqual(releaseGroup.artistCredits, releaseGroup.artistCredit)
}) })